Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add output collectors to support output described in the draft 2020-12 #128

Merged
merged 35 commits into from
Jun 12, 2024
Merged

Add output collectors to support output described in the draft 2020-12 #128

merged 35 commits into from
Jun 12, 2024

Conversation

OptimumCode
Copy link
Owner

Resolves #119

@OptimumCode OptimumCode added enhancement New feature or request ABI breaking changes that break binary compatibility (does not mean they break API) API breaking changes that break API compatibility labels Jun 9, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.33740% with 33 lines in your changes missing coverage. Please review.

Project coverage is 90.76%. Comparing base (7207c36) to head (ba87c05).

Files Patch % Lines
.../github/optimumcode/json/schema/OutputCollector.kt 94.44% 4 Missing and 8 partials ⚠️
...github/optimumcode/json/schema/ValidationOutput.kt 70.27% 2 Missing and 9 partials ⚠️
...mumcode/json/schema/internal/RefSchemaAssertion.kt 86.66% 0 Missing and 2 partials ⚠️
...s/object/ConditionalRequiredPropertiesAssertion.kt 86.66% 1 Missing and 1 partial ⚠️
...n/io/github/optimumcode/json/pointer/extensions.kt 91.66% 0 Missing and 1 partial ⚠️
...github/optimumcode/json/schema/AbsoluteLocation.kt 95.00% 0 Missing and 1 partial ⚠️
...ernal/factories/array/UnevaluatedItemsAssertion.kt 95.83% 1 Missing ⚠️
...nal/factories/array/UniqueItemsAssertionFactory.kt 96.15% 0 Missing and 1 partial ⚠️
...chema/internal/factories/string/LengthAssertion.kt 92.30% 0 Missing and 1 partial ⚠️
...ternal/factories/string/PatternAssertionFactory.kt 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   90.32%   90.76%   +0.44%     
==========================================
  Files         120      124       +4     
  Lines        3203     3637     +434     
  Branches      955     1023      +68     
==========================================
+ Hits         2893     3301     +408     
- Misses         50       56       +6     
- Partials      260      280      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

OptimumCode added 24 commits June 12, 2024 12:53
@OptimumCode
Add information about schema uri for reference
ac49f87
@OptimumCode
Migrate to output collectors
f7d6db5
@OptimumCode
Optimize error transformation
c06d246
@OptimumCode
Rewrite relative method for json pointer
222e69a
@OptimumCode
Add methods to use output collectors. Make sure keyword location is u…
66d52f7 
…pdated even if no errors reported
@OptimumCode
Add tests for output collectors
2e518e2
@OptimumCode
Avoid index parsing when insertLast is used
61f1906
@OptimumCode
Delay allocation of inner collection in collectors until it is really…
7f8714e 
… needed
@OptimumCode
Minimize publich api
9036eec
@OptimumCode
Generate API dump
02a956d
@OptimumCode
Add benchmarks for new output collectors
5d87e75
@OptimumCode
Do not create child collectors for flag output once the failid result…
b99c0a6 
… is determinated
@OptimumCode
Increase nested block depth limit
1acc755
@OptimumCode
Return value instead of using blackhole object
0dd2c71
@OptimumCode
Reduce allocations in outputc collectors. Cache hashcode to avoid dee…
9488dd1 
…p recurcive calculation
@OptimumCode
Correct output classes to match the output schema from draft 2020-12
9694a8c
@OptimumCode
Hide output property from public API
8d90abc
@OptimumCode
Add serizalization for absolute location
67ea7f3
@OptimumCode
Add seriailzation to json pointer
3a3ac20
@OptimumCode
Add serialization to output results
284ac26
@OptimumCode
Make custom serizalizers internal
9df8015
@OptimumCode
Update api dump
26c8283
@OptimumCode
Remove unused index prop during pointer parsing
18f8e27
@OptimumCode
Add additional test case for relative pointer
e6a69ee
@OptimumCode OptimumCode marked this pull request as ready for review June 12, 2024 10:33
@OptimumCode OptimumCode merged commit 4f2e808 into main Jun 12, 2024
10 checks passed
@OptimumCode OptimumCode deleted the issue_#119 branch June 12, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
ABI breaking changes that break binary compatibility (does not mean they break API) API breaking changes that break API compatibility enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: implement output formats described in JSON schema draft 2020-12
1 participant
@OptimumCode